build(eslint): disabling wildcard imports with eslint#31761
Merged
Conversation
rusackas
requested review from
betodealmeida,
eschutho,
geido and
sadpandajoe
as code owners
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Unsafe Date Parsing ▹ view | ✅ |
 |
Avoid ignoring ESLint rule 'no-restricted-syntax'. ▹ view | |
|
Invalid ESLint Disable Comment ▹ view | ✅ |
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/sandbox.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/sandbox.ts
Outdated
Show resolved
Hide resolved
rusackas
changed the title
Member
Author
|
@jpchev do you mean to see what the rules are? There are various eslint.config.js files in the codebase you can look at. If you mean you want to run the script to test it, you can check the |
rusackas
force-pushed
the
disable-namespace-imports
branch
from
23dfabe to
0cc8360
Compare
Contributor
yes thank you, anyway |
rusackas
force-pushed
the
disable-namespace-imports
branch
from
0cc8360 to
7e5ae22
Compare
Member
|
Ooops approved twice... |
sadpandajoe
approved these changes
Jan 14, 2025
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
@justinpark adeptly spotted a wildcard input on a PR here. I figured this might be happening elsewhere, so I added a lint rule, and cleaned up the fallout. This should lead to a smaller bundle size, with any luck, or at least better hygiene.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION