-
Notifications
You must be signed in to change notification settings - Fork 16.6k
feat: WiP support for python 3.12 #31759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
fea3210 to
d3654cb
Compare
|
In our app, to upgrade Pandas to 2.2.3 and still work with SQLAlchemy 1.4.x, we had to change the way we called e.g. So, the likes of this call: superset/superset/models/helpers.py Line 1381 in aae8fda
Would change to read: Worth a try in the places it fails 👍 |
|
This one hasn't been updated since January, should we close it out? |
|
i think this isn't relevant anymore, looks like we're running against |
Gave supporting
3.12a shot while deprecating3.9, made some progress but hit some blockers. Keeping this PR open to keep tabs on what's blocking at this time.pandas==2.0.3does not support py3.12, so bumped to latest, hit some issues, found some worrisome changes apparently inpandas>=2.2.0related to them no supportingdtypearg of typesqlalchemyindf.to_sql(), so reverter to the highest under 2.2, and seems there are issues there. Pandas folks not respecting semver it seems but given the API surface pandas have, gonna be have to evolve that lib without breaking a million things.Python wizards, help is very welcome to help get this through