Skip to content

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 8, 2025

Gave supporting 3.12 a shot while deprecating 3.9, made some progress but hit some blockers. Keeping this PR open to keep tabs on what's blocking at this time.

pandas==2.0.3 does not support py3.12, so bumped to latest, hit some issues, found some worrisome changes apparently in pandas>=2.2.0 related to them no supporting dtype arg of type sqlalchemy in df.to_sql(), so reverter to the highest under 2.2, and seems there are issues there. Pandas folks not respecting semver it seems but given the API surface pandas have, gonna be have to evolve that lib without breaking a million things.

Python wizards, help is very welcome to help get this through

@korbit-ai
Copy link

korbit-ai bot commented Jan 8, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 8, 2025
@mistercrunch mistercrunch force-pushed the python312 branch 2 times, most recently from fea3210 to d3654cb Compare January 9, 2025 00:09
@mistercrunch mistercrunch changed the title feat: support for python 3.12 feat: WiP support for python 3.12 Jan 10, 2025
@rad-pat
Copy link
Contributor

rad-pat commented Jan 13, 2025

In our app, to upgrade Pandas to 2.2.3 and still work with SQLAlchemy 1.4.x, we had to change the way we called e.g. pd.read_sql_query

So, the likes of this call:

df = pd.read_sql_query(sql=sql, con=engine)

Would change to read:

df = pd.read_sql_query(sql=sql, con=engine.raw_connection())

Worth a try in the places it fails 👍

@rusackas
Copy link
Member

This one hasn't been updated since January, should we close it out?

@mistercrunch
Copy link
Member Author

i think this isn't relevant anymore, looks like we're running against next as 3.12 already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code preset-io review:draft size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants