Skip to content

Caravel no data returned exception#314

Closed
gbrian wants to merge 10 commits into
apache:masterfrom
gbrian:caravel_no_data_returned
Closed

Caravel no data returned exception#314
gbrian wants to merge 10 commits into
apache:masterfrom
gbrian:caravel_no_data_returned

Conversation

@gbrian
Copy link
Copy Markdown
Contributor

@gbrian gbrian commented Apr 10, 2016

Hi there,
Not sure if you are interested by I've changed a bit the way "No results" is managed.
I've kept as an exception but created new one NoResultsException, excpetion is returned in a custom header.
Changed the way visualizations notifies error, now they are passing the error object instead only the message.
Finally message is render with another class.

@mistercrunch
Copy link
Copy Markdown
Member

I think you need to rebase

@gbrian
Copy link
Copy Markdown
Contributor Author

gbrian commented Apr 10, 2016

Rebased.
Re ran npm run lint seems not to be working properly on my machine, trying to fix and enabling at PyCharm
I apology for the inconveniences.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.6%) to 70.714% when pulling 0c0b6f2 on gbrian:caravel_no_data_returned into da421bb on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

This PR isn't right (attempting to delete files) reopen it when it's cleaned up

@gbrian
Copy link
Copy Markdown
Contributor Author

gbrian commented Apr 11, 2016

Ouch! Seems I did something wrong during "re-base" operation.
Now fixing and adding a test case.

@gbrian gbrian mentioned this pull request Apr 11, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
isaac-jaynes-imperva added a commit to isaac-jaynes-imperva/superset that referenced this pull request Mar 3, 2026
- Added multi-tenant support.
- Added sample SSO implementation for Auth0.
- Added some tests.
- Allow `--keyword` (like pytest) on `./scripts/tests/run.sh`

---------

Co-authored-by: Joey Andres <joey.andres@cplcloud.com>
Co-authored-by: Hang Shao <hang.shao@thalesgroup.com>
Co-authored-by: Cloud User <ec2-user@ip-172-31-83-61.ec2.internal>
Co-authored-by: isaac-jaynes-imperva <isaac.jaynes@imperva.com>
Co-authored-by: Joey Andres <joey.andres@imperva.com>
Co-authored-by: Joey Andres <jandres@joeyandres.com>
Co-authored-by: Cloud User <anna.berman@thalesgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants