Skip to content

Showing thumbsnails when switching viz#313

Merged
mistercrunch merged 3 commits into
masterfrom
thumbs
Apr 11, 2016
Merged

Showing thumbsnails when switching viz#313
mistercrunch merged 3 commits into
masterfrom
thumbs

Conversation

@mistercrunch
Copy link
Copy Markdown
Member

@mistercrunch mistercrunch mentioned this pull request Apr 10, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 72.335% when pulling fd3502b on thumbs into da421bb on master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling fd3502b on airbnb:thumbs into da421bb on airbnb:master.

1 similar comment
@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling fd3502b on airbnb:thumbs into da421bb on airbnb:master.

@williaster
Copy link
Copy Markdown
Contributor

nice! I think eventually it'd be sweet to have more generic svg outlines, etc. but for now I think screenshots are okay / way better than nothing.

LGTM after rebase?

@sid88in
Copy link
Copy Markdown
Contributor

sid88in commented Apr 11, 2016

SO COOL

@sid88in
Copy link
Copy Markdown
Contributor

sid88in commented Apr 11, 2016

IMO we should make these widgets configurable. For instance, sometimes a given widget is not useful for certain distribution of data. In that case users can still see the widgets available in the drop down. Can we make these widgets configurable so that it can be customized by admin. - Just a thought ;)

@mistercrunch
Copy link
Copy Markdown
Member Author

@sid88in , yeah we could eventually have global settings (withelist/blacklist), and same at the datasource level perhaps.

@mistercrunch mistercrunch merged commit 807d686 into master Apr 11, 2016
@mistercrunch mistercrunch deleted the thumbs branch April 11, 2016 19:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.7 First shipped in 0.8.7 labels Feb 19, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* Showing thumbsnails when switching viz

* Adding missing images

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.7 First shipped in 0.8.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants