Skip to content

Conversation

@Vitor-Avila
Copy link
Contributor

SUMMARY

The Tab and Header UI elements in the dashboard have an AnchorLink. These are currently visible in embedded mode. Embedded users are external that don't have access to the instance directly, so these links should not be visible.

This PR hides AnchorLinks in embedded mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

Tests added. For manual testing:

  1. Create a dashboard containing at least a header and a tab.
  2. Load this dashboard in embedded mode.
  3. Validate the AnchorLinks are not visible.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Vitor-Avila Vitor-Avila requested a review from kgabryje November 29, 2024 11:35
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the tests!

@Vitor-Avila Vitor-Avila merged commit 14682b9 into master Nov 29, 2024
34 checks passed
@rusackas rusackas deleted the fix/embedded/hide-anchorlinks branch December 5, 2024 00:28
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Mar 4, 2025
sadpandajoe pushed a commit that referenced this pull request Mar 4, 2025
@github-actions github-actions bot added 🍒 4.1.2 Cherry-picked to 4.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 24, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
@Rattlyy
Copy link

Rattlyy commented Nov 14, 2025

This broke permalinks on embedded dashboards.

@sadpandajoe
Copy link
Member

This broke permalinks on embedded dashboards.

@Rattlyy this has been closed and pushed to prod for quite a few releases. Mind creating a new issue with repro steps.

@Rattlyy
Copy link

Rattlyy commented Nov 17, 2025

This broke permalinks on embedded dashboards.

@Rattlyy this has been closed and pushed to prod for quite a few releases. Mind creating a new issue with repro steps.

#36132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants