Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): Added fix for some issues #31017

Closed
wants to merge 27 commits into from

Conversation

asher-lab
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Asher Manangan and others added 27 commits October 25, 2024 19:49
DR-4503: Added export Tags functionality for Superset Dashboards and …
DR-4503: Added Import Tags functionality for Superset Dashboards and Charts
DR-4503: Fix Export Tag to ignore owner:
remove docker .env custom SUPERSET_SECRET_KEY
Superset remove unwanted files
Add superset logic to handle disable tagging system
Add Unit Testing for Tag Export and Import in Superset
Fix integration test superset, change to "tags" and update tag filter using TagType apache#30869
* Added self.contents in database and datasets for import

* Add self.content in query for import

* Run precommit and fix some issues in superset

* Add ExportTagsCommand

* Fix ImportExamplesCommand arguments to make Optional

* Remove should_export_tags parameter to solve pre-commit error

* Fix ExportDashboard command calling ExportTagsCommandfrom ExportChartsCommand

* Remove protected access for ExportTagsCommand _export

* Fix some Pylint issues

* Ensure Feature Flag for TAGGING_SYSTEM is turned off

---------

Co-authored-by: Asher Manangan <[email protected]>
…shboard expo… (#14)

* adjust tag export behavior for charts when called from dashboard export command


---------

Co-authored-by: Asher Manangan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant