perf: Prevent redundant calls to getRelevantDataMask

[kgabryje]

SUMMARY

Move getRelevantDataMask and getAllActiveFilters calls from Dashboard's mapStateToProps to a selector.

On a very large dashboard (300+ charts, 40+ filters) those calls delayed the dashboard loading time by over 3 seconds. After this change, they are negligible. Please keep in mind that you likely won't reproduce that delay on a dashboard from sample data, it only occurs on very large ones.

Sidenote - my key takeaway from this is that we really need to optimize our redux selectors with createSelector from redux toolkit more often. Plenty of our selectors have quite complex code that is mostly running unnecessarily.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before - you can see that there's a 3.2s load event task, which really consists of thousands of getRelevantDataMask calls:

After - 0.8ms:

TESTING INSTRUCTIONS

Dashboards with native filters should work just like before

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API