fix: Set correct amount of steps to avoid confusing logs while loading examples #30606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
michael-s-molina
changed the title
michael-s-molina
approved these changes
Oct 15, 2024
michael-s-molina
changed the title
michael-s-molina
changed the title
Member
|
Thank you @deathstrokedarksky! |
mistercrunch
pushed a commit
that referenced
this pull request
Oct 28, 2024
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses an issue with the logging behavior in the
docker/docker-init.shscript when loading examples in Apache Superset. The change ensures that the number of steps logged during the initialization process reflects whether example data should be loaded, thus preventing confusion in the logs. It was actually confusing in my case when I first ran superset in docker in different modes.Changes Made
STEP_CNTvariable initialization logic in thedocker/docker-init.shscript.STEP_CNTproperly.Testing Instructions
SUPSET_LOAD_EXAMPLEScan be set to either"yes"or"no".