chore(scripts): purge node_modules folder on npm prune

[rusackas]

The npm prune script wasn't purging node modules folders, which (AFAIK) should be nuked from time to time. npm install should be run when building/publishing packages, or building/installing superset.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[mistercrunch]

Just a thought but could be good to nuke .temp_cache/ too, mine got to 3GB

$ du -sh .temp_cache/
2.9G    .temp_cache/

after nuking + a rebuild it's about

[rusackas]

@mistercrunch done (finally) :)

[mistercrunch]

Wondering if this npm run prune is ever viable given that it removes the package-lock.json, doesn't that lead to upgrading all packages/sub-packages in a way that's too-much-all-at-once?

[rusackas]

Wondering if this npm run prune is ever viable given that it removes the package-lock.json, doesn't that lead to upgrading all packages/sub-packages in a way that's too-much-all-at-once?

Nope... there shouldn't ever be a need to have package-lock files in packages/plugins. Running npm install from the root superset-frontend directory installs them all for Superset. The package lock files in these plugins/packages aren't needed and in fact cause scripts to fail when building/deploying.