fix(Fave): Charts and Dashboards fave/unfave do not commit transactions

[geido]

SUMMARY

We noticed that when faving/unfaving a Dashboard or a Chart the transaction wasn't being committed. This PR introduces commands and uses the transaction decorator to commit the transactions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

1. Fave/Unfave should save for both charts and dashboards

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[dpgaspar]

Looks good, can you add tests for the NotFound and AccessDenied exceptions

[michael-s-molina]

@geido If possible, could you use a more descriptive name for the commands? Maybe MakeFavoriteCommand and RemoveFavoriteCommand?

[geido]

@geido If possible, could you use a more descriptive name for the commands? Maybe MakeFavoriteCommand and RemoveFavoriteCommand?

If the goal is to help people with finding all code related to favorites I believe AddFavoriteDashboardCommand and DelFavoriteDashboardCommand should be enough. Trying not to create a string that is just too long. These seem already on the edge.