Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct a typo #30123

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore: correct a typo #30123

merged 3 commits into from
Sep 19, 2024

Conversation

dl57934
Copy link
Contributor

@dl57934 dl57934 commented Sep 2, 2024

chore: typo persistance -> persistence

SUMMARY

correct a typo persistance -> persistence

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

helm values.yaml comment change so don't need testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

chore: typo persistance -> persistence
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke
Copy link
Member

sfirke commented Sep 3, 2024

This seems to need code owner review from one of three people so I can't merge it, but looks good to me - thank you!

@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Sep 3, 2024
@rusackas
Copy link
Member

rusackas commented Sep 5, 2024

It seems you need to bump the helm version. I think you can do this by running the pre-commit hooks.

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install
A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

@rusackas
Copy link
Member

rusackas commented Sep 5, 2024

@mistercrunch unless there's a better command to bump the helm charts, we should copy-paste your CI failure logs about pre-commit to this GHA as well. I can do it sometime, if you're not in the mood to do so :)

@dl57934

This comment was marked as outdated.

@dl57934 dl57934 closed this Sep 18, 2024
@dl57934
Copy link
Contributor Author

dl57934 commented Sep 18, 2024

@mistercrunch unless there's a better command to bump the helm charts, we should copy-paste your CI failure logs about pre-commit to this GHA as well. I can do it sometime, if you're not in the mood to do so :)

I applied pre-commit and update helm chart version to 0.12.13

image

@dl57934 dl57934 reopened this Sep 18, 2024
@mistercrunch
Copy link
Member

mistercrunch commented Sep 18, 2024

Based on .github/CODEOWNERS, helm/ need an approval from @dpgaspar or @villebro to be merged

@dpgaspar dpgaspar merged commit 68594d9 into apache:master Sep 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants