Skip to content

Conversation

@sadpandajoe
Copy link
Member

SUMMARY

Fixes issue #29708. When we were adding ruff in #28158, I'm guessing it was removed as these were unused imports.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.69%. Comparing base (76d897e) to head (5ab7fb2).
⚠️ Report is 2419 commits behind head on master.

Files with missing lines Patch % Lines
superset/tasks/celery_app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29921       +/-   ##
===========================================
+ Coverage   60.48%   83.69%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38053    -38183     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31850    -14264     
+ Misses      28017     6203    -21814     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.02% <0.00%> (-0.14%) ⬇️
javascript ?
mysql 76.78% <0.00%> (?)
postgres 76.85% <0.00%> (?)
presto 53.56% <0.00%> (-0.24%) ⬇️
python 83.69% <0.00%> (+20.19%) ⬆️
sqlite 76.34% <0.00%> (?)
unit 60.36% <0.00%> (+2.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I restarted the flaky MySQL IT which had failed

@rusackas rusackas merged commit 9f5eb89 into apache:master Aug 12, 2024
@rusackas rusackas deleted the joe/add-imports-back-to-celery branch August 12, 2024 22:21
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 12, 2024
sadpandajoe added a commit that referenced this pull request Aug 13, 2024
@github-actions github-actions bot added 🍒 4.1.0 Cherry-picked to 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
@mistercrunch mistercrunch added the 🍒 4.1.1 Cherry-picked to 4.1.1 label Nov 27, 2024
@github-actions github-actions bot added the 🍒 4.1.2 Cherry-picked to 4.1.2 label Apr 1, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 Cherry-picked to 4.1.0 🍒 4.1.1 Cherry-picked to 4.1.1 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants