Skip to content

Conversation

@kgabryje
Copy link
Member

@kgabryje kgabryje commented Aug 12, 2024

SUMMARY

Enable injecting custom <link>, <meta>, <style> etc. elements into .

Similarly to how tail_js_custom_extra.html works, this PR adds head_custom_extra.html file where users can define elements that will be injected into head.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Add some html code to head_custom_extra.html file, verify that it appears in <head>

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend global:theming Related to theming Superset labels Aug 12, 2024
@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.70%. Comparing base (76d897e) to head (b2136de).
⚠️ Report is 2203 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29917       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38052    -38184     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31851    -14263     
+ Misses      28017     6201    -21816     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.02% <ø> (-0.14%) ⬇️
javascript ?
mysql 76.76% <ø> (?)
postgres 76.86% <ø> (?)
presto 53.56% <ø> (-0.24%) ⬇️
python 83.70% <ø> (+20.19%) ⬆️
sqlite 76.34% <ø> (?)
unit 60.36% <ø> (+2.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kgabryje kgabryje merged commit c016ca5 into apache:master Aug 12, 2024
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend global:theming Related to theming Superset size/S 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants