Skip to content

Conversation

@justinpark
Copy link
Member

@justinpark justinpark commented Aug 9, 2024

SUMMARY

Following up #27645, This commit includes the migration of the component used for SQLLab results from the ant-table component to the ag-grid component.
During this process, the existing logic(getWidthsForColumns) that measured column size to adjust the width was removed because it was not only performance-intensive but also unnecessary, as the resizable column option in ag-grid allows users to adjust the width as needed.
Additionally, other property options were modified to ensure compatibility with ag-grid. Moreover, a column menu feature was added, enabling users to pin specific columns and apply filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-08-09 at 7 33 03 AM

After:

Screenshot 2024-08-20 at 11 46 53 AM

Header menu (Actions):

Image

TESTING INSTRUCTIONS

Go to SQL Lab and run a query to explore the data

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend sqllab Namespace | Anything related to the SQL Lab labels Aug 9, 2024
@kasiazjc
Copy link
Contributor

@justinpark this looks great! I think I might have asked this question before, so apologies if I did, but for how long custom table settings are kept - just for session and just for this specific query?

@yousoph
Copy link
Member

yousoph commented Aug 12, 2024

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.160.157.54:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@justinpark
Copy link
Member Author

justinpark commented Aug 13, 2024

how long custom table settings are kept - just for session and just for this specific query?

You're right. This will only apply to the current query in the current session. I considered saving it, but I thought it might be better not to, as revisiting the query later when the memory has faded could cause confusion with different items being displayed in the query results.

@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (76d897e) to head (3d526f3).
Report is 1358 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29900       +/-   ##
===========================================
+ Coverage   60.48%   83.46%   +22.97%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39276    -36960     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32783    -13331     
+ Misses      28017     6493    -21524     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.77% <ø> (-0.40%) ⬇️
javascript ?
mysql 75.99% <ø> (?)
postgres 76.05% <ø> (?)
presto 53.26% <ø> (-0.54%) ⬇️
python 83.46% <ø> (+19.98%) ⬆️
sqlite 75.53% <ø> (?)
unit 61.04% <ø> (+3.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hokwang
Copy link

Hokwang commented Nov 11, 2024

when is the release target date and release version ?

@justinpark justinpark force-pushed the feat--ag-grid-for-filterable-table branch from 61e0bb6 to 741b5b1 Compare December 10, 2024 23:14
@eschutho
Copy link
Member

when is the release target date and release version ?

@Hokwang this will most likely be released in 5.0 around April 2025.

@eschutho
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@github-actions
Copy link
Contributor

@justinpark Processing your ephemeral environment request here.

@github-actions
Copy link
Contributor

@justinpark Ephemeral environment spinning up at http://52.33.205.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@justinpark justinpark force-pushed the feat--ag-grid-for-filterable-table branch from 3d526f3 to e5b0967 Compare January 28, 2025 00:42
@justinpark justinpark force-pushed the feat--ag-grid-for-filterable-table branch from e5b0967 to de95ae8 Compare January 31, 2025 00:20
@justinpark justinpark merged commit f73d61a into apache:master Jan 31, 2025
48 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend dependencies:npm size/XXL sqllab Namespace | Anything related to the SQL Lab 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants