Skip to content

fix(Dashboard): Copying a Dashboard does not commit the transaction #29776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2024
Merged

fix(Dashboard): Copying a Dashboard does not commit the transaction #29776

merged 5 commits into from
Jul 31, 2024

Conversation

@geido
Copy link
Member

@geido geido commented Jul 30, 2024

SUMMARY

We noticed that when copying a Dashboard the transaction wasn't being committed. This PR introduces a command for the dashboard copy operation and uses the transaction decorator to commit the transaction.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Copy a Dashboard
  2. The Dashboard should be copied successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido changed the title fix(Dashboard) Copying a Dashboard does not commit the transaction fix(Dashboard): Copying a Dashboard does not commit the transaction Jul 30, 2024
@github-actions github-actions bot added the api Related to the REST API label Jul 30, 2024
@dosubot dosubot bot added dashboard Namespace | Anything related to the Dashboard dashboard:error Related to Dashboard errors labels Jul 30, 2024
@geido geido requested a review from kgabryje July 30, 2024 13:24
@geido
Copy link
Member Author

geido commented Jul 30, 2024

/testenv up

@michael-s-molina
Copy link
Member

michael-s-molina commented Jul 30, 2024

@geido Would you mind also fixing delete_embedded and copy_dash?

@geido
Copy link
Member Author

geido commented Jul 30, 2024

@geido Would you mind also fixing delete_embedded and copy_dash?

I will in follow-ups.

kgabryje
kgabryje approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

michael-s-molina
michael-s-molina reviewed Jul 30, 2024
View reviewed changes
michael-s-molina
michael-s-molina reviewed Jul 30, 2024
View reviewed changes
@sadpandajoe
Copy link
Member

sadpandajoe commented Jul 30, 2024

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
@geido
Copy link
Member Author

geido commented Jul 31, 2024

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024

@geido Ephemeral environment spinning up at http://35.94.9.47:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 4c52ecc into master Jul 31, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe
Copy link
Member

sadpandajoe commented Aug 1, 2024

@supersetbot label 4.1

@geido geido mentioned this pull request Aug 8, 2024
Merged
9 tasks
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@geido @sadpandajoe
fix(Dashboard): Copying a Dashboard does not commit the transaction (#…
7219310 
…29776)

(cherry picked from commit 4c52ecc)
@rusackas rusackas deleted the geido/fix/copy-dash-missing-transaction branch September 27, 2024 20:54
@github-actions github-actions bot added 🍒 4.1.0 Cherry-picked to 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
@mistercrunch mistercrunch added the 🍒 4.1.1 Cherry-picked to 4.1.1 label Nov 27, 2024
@github-actions github-actions bot added the 🍒 4.1.2 Cherry-picked to 4.1.2 label Apr 1, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgabryje kgabryje kgabryje approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees

No one assigned

Labels

api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:error Related to Dashboard errors dashboard Namespace | Anything related to the Dashboard size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 Cherry-picked to 4.1.0 🍒 4.1.1 Cherry-picked to 4.1.1 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geido @michael-s-molina @sadpandajoe @kgabryje @mistercrunch