Skip to content

fix: Dashboard editable title weird behavior when adding spaces #29667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: Dashboard editable title weird behavior when adding spaces #29667

merged 1 commit into from
Jul 23, 2024

Conversation

@kgabryje
Copy link
Member

@kgabryje kgabryje commented Jul 23, 2024

SUMMARY

When user added trailing spaces to dashboard's title in edit mode, the input's width wasn't updating as expected, causing weird behaviour (like in the recording). Adding white-space: pre style causes the trailing spaces to not be ignored by resize observers.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2024-07-23.at.14.19.26.mov

After:

Screen.Recording.2024-07-23.at.14.11.48.mov

TESTING INSTRUCTIONS

  1. Open a dashboard in edit mode
  2. Add some trailing spaces to the suffix
  3. Verify that the input scales as expected

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje requested a review from geido July 23, 2024 12:22
@dosubot dosubot bot added the dashboard:editmode Related to te Dashboard edit mode label Jul 23, 2024
@kgabryje kgabryje force-pushed the fix/dashboard-editable-title branch from 7beae13 to 53ec5de Compare July 23, 2024 12:31
@kgabryje kgabryje merged commit 453e6de into apache:master Jul 23, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@kgabryje @eschutho
fix: Dashboard editable title weird behavior when adding spaces (#29667)
584db2c
@sadpandajoe
Copy link
Member

sadpandajoe commented Jul 30, 2024

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@kgabryje @sadpandajoe
fix: Dashboard editable title weird behavior when adding spaces (#29667)
3d7f6da 
(cherry picked from commit 453e6de)
@github-actions github-actions bot added 🍒 4.1.0 Cherry-picked to 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
@mistercrunch mistercrunch added the 🍒 4.1.1 Cherry-picked to 4.1.1 label Nov 27, 2024
@github-actions github-actions bot added the 🍒 4.1.2 Cherry-picked to 4.1.2 label Apr 1, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:editmode Related to te Dashboard edit mode size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 Cherry-picked to 4.1.0 🍒 4.1.1 Cherry-picked to 4.1.1 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kgabryje @sadpandajoe @geido @mistercrunch