fix(dataset): Obscure error message on creation#29554
Open
justinpark wants to merge 4 commits intoapache:masterfrom
Open
fix(dataset): Obscure error message on creation#29554justinpark wants to merge 4 commits intoapache:masterfrom
justinpark wants to merge 4 commits intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29554 +/- ##
==========================================
+ Coverage 60.48% 64.88% +4.39%
==========================================
Files 1931 524 -1407
Lines 76236 37779 -38457
Branches 8568 0 -8568
==========================================
- Hits 46114 24513 -21601
+ Misses 28017 13266 -14751
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@justinpark do you still intend to merge this one? |
Member
|
Hi @justinpark! Just following up on this one too - still on your radar? Let us know if you'd like to move forward with it or if we should close it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up #25669 and #24969
This commit adds the SupersetSecurityException case that displays the error message from the statement validation error.
(When a SupersetSecurityException error is thrown while creating a dataset, it only shows "Fater Error" error message.)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS
Go to SQL Lab and create an invalid select statement (
(SELECT 1)with parentheses)Create a dataset and see the error message
ADDITIONAL INFORMATION