Skip to content

fix(dataset): Obscure error message on creation#29554

Open
justinpark wants to merge 4 commits intoapache:masterfrom
justinpark:fix--obscure--error-message-on-dataset-creation
Open

fix(dataset): Obscure error message on creation#29554
justinpark wants to merge 4 commits intoapache:masterfrom
justinpark:fix--obscure--error-message-on-dataset-creation

Conversation

@justinpark
Copy link
Member

@justinpark justinpark commented Jul 10, 2024

SUMMARY

Following up #25669 and #24969
This commit adds the SupersetSecurityException case that displays the error message from the statement validation error.
(When a SupersetSecurityException error is thrown while creating a dataset, it only shows "Fater Error" error message.)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2023-10-16 at 4 32 05 PM

After:
Screenshot 2023-10-16 at 4 41 52 PM

TESTING INSTRUCTIONS

Go to SQL Lab and create an invalid select statement ((SELECT 1) with parentheses)
Create a dataset and see the error message

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added data:dataset Related to dataset configurations global:error Related to global errors affecting the platform labels Jul 10, 2024
@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.88%. Comparing base (76d897e) to head (5bf2bcd).
Report is 443 commits behind head on master.

Files Patch % Lines
superset/commands/dataset/exceptions.py 66.66% 3 Missing ⚠️
superset/utils/decorators.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29554      +/-   ##
==========================================
+ Coverage   60.48%   64.88%   +4.39%     
==========================================
  Files        1931      524    -1407     
  Lines       76236    37779   -38457     
  Branches     8568        0    -8568     
==========================================
- Hits        46114    24513   -21601     
+ Misses      28017    13266   -14751     
+ Partials     2105        0    -2105     
Flag Coverage Δ
hive 49.13% <66.66%> (-0.04%) ⬇️
javascript ?
presto 53.71% <66.66%> (-0.09%) ⬇️
python 64.88% <66.66%> (+1.39%) ⬆️
unit 59.73% <66.66%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

@justinpark do you still intend to merge this one?

@rusackas
Copy link
Member

Hi @justinpark! Just following up on this one too - still on your radar? Let us know if you'd like to move forward with it or if we should close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:dataset Related to dataset configurations global:error Related to global errors affecting the platform size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants