Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Upgrade Card to Ant Design 5 #29389

Merged
merged 2 commits into from
Jul 8, 2024
Merged

refactor: Upgrade Card to Ant Design 5 #29389

merged 2 commits into from
Jul 8, 2024
+34 −5

Conversation

geido
Copy link
Member

@geido geido commented Jun 27, 2024 •
edited
Loading

SUMMARY

Please refer to the Superset Improvement Proposal #29268
This PR is dependent on PR #29328

BEFORE

340085332-5de2ad94-0afb-4d7f-8f9f-33ce554bbc2c

340427238-aad69ebe-e0ff-4531-aa9e-f83a63c5914a

AFTER

340085312-fb3b77c4-e48b-4d92-a4a3-4444c99e702d

340427238-aad69ebe-e0ff-4531-aa9e-f83a63c5914a

TESTING INSTRUCTIONS

  1. Verify the usage of the Card throughout the application.
  2. Ensure no visual or behavioral changes have been introduced.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido marked this pull request as ready for review July 8, 2024 09:55
@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor Related to refactoring the frontend labels Jul 8, 2024
Antonio-RiveroMartnez
Antonio-RiveroMartnez approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geido geido merged commit e768796 into master Jul 8, 2024
37 of 60 checks passed
@rusackas
Copy link
Member

rusackas commented Jul 8, 2024

@geido does the Storybook for this need any additional eyes or followup? Happy to help.

@rusackas rusackas deleted the geido/refactor/antd5-card branch July 8, 2024 17:11
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@geido @eschutho
refactor: Upgrade Card to Ant Design 5 (#29389)
1cba54c
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
@geido geido mentioned this pull request Nov 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend frontend:refactor:antd5 frontend:refactor Related to refactoring the frontend size/M 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @rusackas @Antonio-RiveroMartnez @john-bodley