Skip to content

Conversation

@fabianmenges
Copy link
Contributor

@fabianmenges fabianmenges commented Jun 9, 2017

Pandas ExtensionDtypes are not handled correctly in SQL Lab.

image

If a SQL column is of type TIMESTAMP and supports timezones, pandas returns an object of type DatetimeTZDtype https://github.com/pandas-dev/pandas/blob/v0.20.2/pandas/io/sql.py#L911

DatetimeTZDtype is a np.dtype duck-typed class but not a real numpy dtype.

@fabianmenges fabianmenges force-pushed the ExtensionDtypes branch 2 times, most recently from f471a28 to 93199c7 Compare June 21, 2017 14:00
@tobad357
Copy link

tobad357 commented Sep 7, 2017

Will this one be merged or should we do a custom patch? It's causing some issues for us.

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage increased (+0.004%) to 69.121% when pulling 14ff3dd on tc-dc:ExtensionDtypes into 147c12d on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 69.121% when pulling 14ff3dd on tc-dc:ExtensionDtypes into 147c12d on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 69.121% when pulling 14ff3dd on tc-dc:ExtensionDtypes into 147c12d on apache:master.

@mistercrunch mistercrunch merged commit 490c707 into apache:master Sep 12, 2017
@fabianmenges fabianmenges deleted the ExtensionDtypes branch September 19, 2017 18:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 First shipped in 0.20.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants