fix(mixed-timeseries-plugin): Second query stacks stacked on top of first query series #29119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst query series
kgabryje
requested review from
mistercrunch,
Antonio-RiveroMartnez,
geido and
michael-s-molina
dosubot
bot
added
viz:charts:echarts
villebro
approved these changes
Jun 9, 2024
| @@ -225,6 +227,9 @@ export function transformSeries( | |||
| } else if (stack && isTrend) { | |||
| stackId = getTimeCompareStackId(forecastSeries.type, timeCompare, name); | |||
| } | |||
| if (stackId && stackIdSuffix) { | |||
| stackId += stackIdSuffix; | |||
There was a problem hiding this comment.
maybe a nit, but a cybersec person once said that you should always use \n as the separator in composite keys in cases where it's unlikely to appear naturally in the original keys. I'm not sure there's lots of collision risk here, but just in case I'd probably use \n instead of _.
michael-s-molina
added
the
v4.0
mistercrunch
added
🍒 4.0.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In Mixed Series chart, when user sets "Stack" option to true for both queries, the series of the second query are stacked on top of the series of the first query. The reason for that is that both queries could have the same stack ids.
This PR introduces
stackIdSuffix, which adds_aand_bsuffixes to stack ids of queries A and B to ensure that they're unique.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In the screenshots - the bars represent the second query. Before, they were stacked on top of the series from 1st query.
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION