Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not close database modal on mask click #28750

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: do not close database modal on mask click #28750

merged 1 commit into from
May 29, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

Small UI improvement, when someone is working on connecting a database, if they click away the modal will close and they will lose all their work. This just disables the close on click away property.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

eschutho
eschutho commented May 29, 2024
View reviewed changes
superset-frontend/src/features/databases/DatabaseModal/index.tsx
{confirmOverwriteField()}
{importingErrorAlert()}
{passwordNeededField()}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just alphabetized here a bit

@eschutho eschutho marked this pull request as ready for review May 29, 2024 00:16
@dosubot dosubot bot added the change:frontend Requires changing the frontend label May 29, 2024
rusackas
rusackas approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eschutho eschutho merged commit cbd3fa2 into master May 29, 2024
39 of 56 checks passed
@rusackas rusackas deleted the elizabeth/db-modal-close branch May 30, 2024 05:13
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 30, 2024
michael-s-molina pushed a commit that referenced this pull request May 30, 2024
@eschutho @michael-s-molina
fix: do not close database modal on mask click (#28750)
75c7416 
(cherry picked from commit cbd3fa2)
michael-s-molina pushed a commit that referenced this pull request May 30, 2024
@eschutho @michael-s-molina
fix: do not close database modal on mask click (#28750)
37f5430 
(cherry picked from commit cbd3fa2)
michael-s-molina pushed a commit that referenced this pull request May 30, 2024
@eschutho @michael-s-molina
fix: do not close database modal on mask click (#28750)
0e5593f 
(cherry picked from commit cbd3fa2)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@eschutho @EnxDev
fix: do not close database modal on mask click (apache#28750)
733cd41
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eschutho @rusackas @mistercrunch @michael-s-molina