feat: add Nightingale chart support for echarts pie chart#28597
feat: add Nightingale chart support for echarts pie chart#28597rusackas merged 5 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Pretty cool! Are you aware of any feature-parity issues that would prevent a migration from the legacy rose chart to this? I'm always excited to deprecate/remove a legacy plugin in favor of a newer option :) Also, would you mind adding this to the React Storybook entry? We're making a renewed effort to capture as many variants as possible there (interactive or static). |
There was a problem hiding this comment.
Thank you for the PR @hexcafe. Could you also add a screenshot of a Nightingale chart to the Pie viz gallery examples and make sure the Pie chart appears if you search for Nightingale? This will allow people to discover the chart.
Right now we have 4 screenshots. I think you can remove the last 2 and add yours.
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Pie/types.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Pie/types.ts
Outdated
Show resolved
Hide resolved
@rusackas I checked and the legacy plugin has no additional feature that would prevent us from migrating. 
|
|
@michael-s-molina Thanks! I have updated the metadata. Now, we can discover the chart by searching for "Nightingale". |
|
@rusackas @michael-s-molina Should we upgrade to ECharts v5.5.0 soon? please take a look at #27341 , Thanks! |
|
Hi @michael-s-molina , Sorry for the delay. I have fixed the type errors. I hope this PR can be merged soon. Thank you! |
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
@hexcafe Thank you for the feature and for addressing all comments!
michael-s-molina
added
the
merge-if-green
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
LGTM2! Thank you for this! Approving CI to run, and will spin up a test environment just to give it one last test drive :)
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://34.216.33.80:8080. Credentials are |
|
Works great! Thanks again! |
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
4 participants
SUMMARY
Add Nightingale Chart Support for Echarts Pie Chart
Echarts now supports Nightingale charts in pie charts, with two optional modes:
radius: Uses the central angle to show the percentage of data and the radius to show data size.area: All sectors share the same central angle, with data size shown only through radiuses.I have added a new option, 'ROSE TYPE,' to support this feature.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION