Skip to content

fix(package-lock): node_modules/@react/types to 16.9.53#27448

Closed
justinpark wants to merge 1 commit into
apache:masterfrom
justinpark:fix--bump-up-types-react
Closed

fix(package-lock): node_modules/@react/types to 16.9.53#27448
justinpark wants to merge 1 commit into
apache:masterfrom
justinpark:fix--bump-up-types-react

Conversation

@justinpark
Copy link
Copy Markdown
Member

@justinpark justinpark commented Mar 8, 2024

SUMMARY

During the implementation of #26011, @types/react was upgraded to 16.9.53, and as a result, package-lock selected the 16.14.51 version.

feat_telemetry___Adding_Scarf_based_telemetry_to_Superset___26011__·_apache_superset_8437a23

Here at Airbnb, our internal dependencies are not yet compatible with types/react@16.14.51, thereby posing a hurdle for our release. We intend to explore compatibility with 16.14.51 in Superset 5.0 or later versions, although the timing is not ideal right now.

This commit modifies the package-lock to reflect the same version number as outlined in #26011.
Simultaneously, we've also lowered @ant-design/icons@5.2.6 (#26727) to 5.0.1, due to its incompatibility with 16.9.53.

TESTING INSTRUCTIONS

npm run type

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`;
return process.env.SCARF_ANALYTICS === 'false' ? null : (
<img
// @ts-ignore
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This referrerPolicy value is compatible with 16.9.53

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (fde93dc) to head (eb77c31).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27448   +/-   ##
=======================================
  Coverage   67.34%   67.34%           
=======================================
  Files        1909     1909           
  Lines       74623    74623           
  Branches     8324     8324           
=======================================
  Hits        50255    50255           
  Misses      22314    22314           
  Partials     2054     2054           
Flag Coverage Δ
javascript 57.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can guarantee that this is bound to come up again as next week @dependabot is going to try to push this up again. You should put some sort of comment around the pin around why it's pinned, that or a dependabot rule with associated comment/documentation as to why it needs to be pinned - or both

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

I'm upset that json and therefore package.json doesn't support comments! - but there are hacks to bring comments in there. I wonder if we could move to a package.js but some tools don't support it (say unclear if dependabot works when using a package.js?).

@justinpark
Copy link
Copy Markdown
Member Author

Can guarantee that this is bound to come up again as next week @dependabot is going to try to push this up again. You should put some sort of comment around the pin around why it's pinned, that or a dependabot rule with associated comment/documentation as to why it needs to be pinned - or both

I identified the compatible version for our internal dependencies, so we can proceed to close this pull request as it stands now. As previously discussed, my intention is to incorporate TypeScript checking into our CI step. Hopefully, this will help us to identify any Dependabot issues at an earlier stage.

@justinpark justinpark closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants