fix(package-lock): node_modules/@react/types to 16.9.53#27448
fix(package-lock): node_modules/@react/types to 16.9.53#27448justinpark wants to merge 1 commit into
Conversation
| const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`; | ||
| return process.env.SCARF_ANALYTICS === 'false' ? null : ( | ||
| <img | ||
| // @ts-ignore |
There was a problem hiding this comment.
This referrerPolicy value is compatible with 16.9.53
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27448 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 1909 1909
Lines 74623 74623
Branches 8324 8324
=======================================
Hits 50255 50255
Misses 22314 22314
Partials 2054 2054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Can guarantee that this is bound to come up again as next week @dependabot is going to try to push this up again. You should put some sort of comment around the pin around why it's pinned, that or a dependabot rule with associated comment/documentation as to why it needs to be pinned - or both
I'm upset that json and therefore package.json doesn't support comments! - but there are hacks to bring comments in there. I wonder if we could move to a package.js but some tools don't support it (say unclear if dependabot works when using a package.js?).
I identified the compatible version for our internal dependencies, so we can proceed to close this pull request as it stands now. As previously discussed, my intention is to incorporate TypeScript checking into our CI step. Hopefully, this will help us to identify any Dependabot issues at an earlier stage. |
SUMMARY
During the implementation of #26011, @types/react was upgraded to
16.9.53, and as a result, package-lock selected the16.14.51version.Here at Airbnb, our internal dependencies are not yet compatible with
types/react@16.14.51, thereby posing a hurdle for our release. We intend to explore compatibility with 16.14.51 in Superset 5.0 or later versions, although the timing is not ideal right now.This commit modifies the
package-lockto reflect the same version number as outlined in #26011.Simultaneously, we've also lowered @ant-design/icons@5.2.6 (#26727) to 5.0.1, due to its incompatibility with 16.9.53.
TESTING INSTRUCTIONS
npm run type
ADDITIONAL INFORMATION