Skip to content

Comments

fix(sqllab): Missing empty query result state#27313

Merged
michael-s-molina merged 1 commit intoapache:masterfrom
justinpark:fix--sqllab-missing-default-result-pane-msg
Mar 1, 2024
Merged

fix(sqllab): Missing empty query result state#27313
michael-s-molina merged 1 commit intoapache:masterfrom
justinpark:fix--sqllab-missing-default-result-pane-msg

Conversation

@justinpark
Copy link
Member

Fixes #27311

SUMMARY

This commit fixes the missing empty query result placeholder.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2024-02-29 at 4 48 18 PM

After:
Screenshot 2024-02-29 at 4 43 02 PM

TESTING INSTRUCTIONS

Open a new tab in SQL Lab and check the result panel message

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Mar 1, 2024
@justinpark justinpark force-pushed the fix--sqllab-missing-default-result-pane-msg branch from 8f6e937 to 4c2d4e2 Compare March 1, 2024 00:56
@pull-request-size pull-request-size bot added size/S and removed size/L labels Mar 1, 2024
@justinpark justinpark changed the title Fix sqllab missing default result pane msg fix(sqllab): Missing empty query result state Mar 1, 2024
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinpark!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit ae8ec9c into apache:master Mar 1, 2024
michael-s-molina pushed a commit that referenced this pull request Mar 4, 2024
@mistercrunch mistercrunch added 🍒 4.0.0 Cherry-picked to 4.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Apr 17, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@mistercrunch mistercrunch added 🍒 4.0.1 Cherry-picked to 4.0.1 🍒 4.0.2 Cherry-picked to 4.0.2 labels Jul 2, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added the 🚢 4.1.0 First shipped in 4.1.0 label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.0 Cherry-picked to 4.0.0 🍒 4.0.1 Cherry-picked to 4.0.1 🍒 4.0.2 Cherry-picked to 4.0.2 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Placeholder image is missing in sql lab for new tabs

4 participants