docs(import_datasources): Remove legacy documentation and update current use#27290
docs(import_datasources): Remove legacy documentation and update current use#27290sfirke merged 8 commits intoapache:masterfrom
Conversation
|
I'm unfamiliar with the technical aspect of this but appreciate you keeping the docs updated! My only concern would be if this only applies to the latest version (I see the PR is tagged 4.0 / 3.1) and we would want to keep the older info for users of older versions. Did this documentation even work before your patch, it sounds like it was broken? If it worked for a reasonably recent version (say 2.0.0 or later) I'd be inclined to preserve it. Ideally there'd be a way to link to an older static version of the docs, but I don't think that's possible, so anything useful could be preserved in a section labeled as such. |
|
@sfirke thanks for the input. I went ahead and undid the deletion of the legacy documentation, and instead labled it as I also added clarification for using the |
|
Thanks for the changes. To check my understanding, are there three scenarios to cover:
Is that right? Right now 1. is covered, but the legacy piece could be clearer in how it covers both 2 & 3. Sorry if this feels like I'm belaboring this or if I'm misunderstanding. |
Specify versions points Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@sfirke Glad you brought that up, I hadn't considered upgrading across versions as I had gotten into this from just deploying a specific versions. Your 3 points are definitely valid, so I added a couple more sections to the Legacy section to cover them. |
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
|
thank you @ddxv for this great update to the docs! 🙌 |
…ent use (apache#27290) Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
…ent use (apache#27290) Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
SUMMARY
The documentation was still referencing the "legacy_import_datasources". I updated to the current expected use for ZIP files and
--usernameoption based on #27154.I have removed the documentation which was for
legacy_import_datasourcesbased on the assumption that this is not expected to be supported.If we would like to keep supporting the
legacy_import_datasourcesI can add it back into the docs with it's own titled section.Please let me know what works best.
ADDITIONAL INFORMATION