Skip to content

fix(ci): docker builds don't work from remote forks#27282

Merged
dpgaspar merged 1 commit intomasterfrom
fix_docker_again2
Feb 28, 2024
Merged

fix(ci): docker builds don't work from remote forks#27282
dpgaspar merged 1 commit intomasterfrom
fix_docker_again2

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 28, 2024

SUMMARY

Fix issues relate to multi-platform builds not working with --load.

Lots of intricacies around multi-platform builds somehow (doesn't work on OSx, doesn't work with --load, and somehow can't --push from remote forks, ...)

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 0383bed into master Feb 28, 2024
@rusackas rusackas deleted the fix_docker_again2 branch February 28, 2024 22:23
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 First shipped in 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/S 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants