Skip to content

Comments

fix: unlock and bump werkzeug#27164

Merged
dpgaspar merged 7 commits intoapache:masterfrom
preset-io:fix/bump-werkzeug
Feb 20, 2024
Merged

fix: unlock and bump werkzeug#27164
dpgaspar merged 7 commits intoapache:masterfrom
preset-io:fix/bump-werkzeug

Conversation

@dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 19, 2024

SUMMARY

Unlocks and bumps Werkzeug to 3.0.1.
Locked here: #23965

The following dependencies need to be bumped also to unlock Werkzeug:

  • Flask-AppBuilder done here
  • Flask-Login
  • Flask-Wtf

Note:
Using OpenID (not OpenID connect) will not be compatible with this bump, but users will not be forced to do it.
Flask-AppBuilder as deprecated this form of Auth.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

Linking the original PR that added bounds on werkzeug: #23965

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7c5773) 67.19% compared to head (ddde709) 67.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27164   +/-   ##
=======================================
  Coverage   67.19%   67.20%           
=======================================
  Files        1905     1905           
  Lines       74498    74498           
  Branches     8323     8323           
=======================================
+ Hits        50061    50067    +6     
+ Misses      22382    22376    -6     
  Partials     2055     2055           
Flag Coverage Δ
mysql 77.99% <ø> (-0.02%) ⬇️
postgres 78.12% <ø> (+0.01%) ⬆️
python 78.26% <ø> (+0.01%) ⬆️
sqlite 77.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar merged commit 3eedcb4 into apache:master Feb 20, 2024
@dpgaspar dpgaspar deleted the fix/bump-werkzeug branch February 20, 2024 10:42
@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Feb 20, 2024
@michael-s-molina michael-s-molina removed the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Feb 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 First shipped in 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.0.0 First shipped in 4.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants