chore(actions): chill out on docker builds

[rusackas]

SUMMARY

This needs discussion!

Does anyone see a need for docker builds on every PR? The only purpose seems to be as a canary for docker builds on master. Now that this takes about 75 minutes of build time for every PR, I think we should just stop it, and bring back a more optimized/parallelized version if someone wants to invest in that. People keep an eye on builds on master pretty regularly, so let's just revert anything that breaks this if/when we need to.

Hopefully, this will save a lot of coal out there somewhere in the world.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69b5701) 69.49% compared to head (17a7758) 69.49%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26695      +/-   ##
==========================================
- Coverage   69.49%   69.49%   -0.01%     
==========================================
  Files        1892     1892              
  Lines       74092    74092              
  Branches     8243     8243              
==========================================
- Hits        51488    51487       -1     
- Misses      20535    20536       +1     
  Partials     2069     2069              

Flag	Coverage Δ
hive	53.88% <ø> (ø)
javascript	56.86% <ø> (ø)
mysql	78.05% <ø> (-0.01%)	⬇️
postgres	78.15% <ø> (ø)
presto	53.83% <ø> (ø)
python	83.04% <ø> (-0.01%)	⬇️
sqlite	77.73% <ø> (ø)
unit	56.40% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

@rusackas I think the ephemeral environments need these docker builds. If we disable this for PRs, then I fear we won't be able to use eph envs anymore. Maybe introduce a new tag that tells CI to build docker images, or something similar?

[craig-rueda]

Also, removing them from PRs will make it impossible to test any docker changes before merging.

[rusackas]

Fair enough... killing this idea 🗡️

[rusackas]

@craig-rueda @villebro if you can, please take a look at this then, so hopefully we can get these slow builds to be less of a blocker.