fix(dashboard): Chart menu disable is fixed on chart-fullscreen in issue #25992 #26410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
approved these changes
Jan 4, 2024
Member
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix @sivasathyaseeelan!
michael-s-molina
added
v3.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26410 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1946 1946
Lines 75990 75993 +3
Branches 8479 8480 +1
=======================================
+ Hits 52544 52547 +3
Misses 21267 21267
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
added
review:checkpoint
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
…sue apache#25992 (apache#26410) (cherry picked from commit d0ffe9a)
mistercrunch
added
🍒 3.0.3
mistercrunch
added
🍒 3.1.2
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR solves the issue mentioned in #25992. I have passed zindex of 101 if in fullsize else 99 to NoAnimationDropdown component as dropdownOverlayStyle props from SliceHeaderControls and similarly changed all files which uses NoAnimationDropdown component
BEFORE
Screencast.from.04-01-24.02.26.38.PM.IST.webm
AFTER
Screencast.from.04-01-24.02.28.08.PM.IST.webm
TESTING INSTRUCTIONS
Kindle select any dashboard and use the dropdown menu in top right corner of any graph and select Enter fullscreen. Now u can access the dropdown in fullscreen
ADDITIONAL INFORMATION