Skip to content

Conversation

@michael-s-molina
Copy link
Member

SUMMARY

#26087 added support for numerical x-axis but ended up introducing #26255 and #26256 because ECharts does not support stacked charts with numerical x-axis. This PR converts the x-axis to type category when a chart is stacked.

Fixes: #26255
Fixes: #26256

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-12-13 at 11 14 13 Screenshot 2023-12-13 at 11 13 16

TESTING INSTRUCTIONS

1 - Create a stacked chart with a numerical x-axis
2 - Make sure the axis and tooltip are calculated correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (578a899) to head (3c80862).
Report is 2263 commits behind head on master.

Files with missing lines Patch % Lines
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26264      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75948    75948              
  Branches     8460     8460              
==========================================
- Hits        52545    52542       -3     
- Misses      21218    21221       +3     
  Partials     2185     2185              
Flag Coverage Δ
javascript 56.50% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak with authority to the code so would like @villebro to review as well - but the fix looks good to me on the surface!

Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to unblock. Let's collab on adding upstream support for this to ECharts.

@michael-s-molina michael-s-molina merged commit 429e2a3 into apache:master Dec 13, 2023
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 13, 2023
michael-s-molina added a commit that referenced this pull request Dec 15, 2023
michael-s-molina added a commit that referenced this pull request Dec 18, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🍒 3.1.0 Cherry-picked to 3.1.0 🍒 3.1.1 Cherry-picked to 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@github-actions github-actions bot added 🍒 3.1.2 Cherry-picked to 3.1.2 🍒 3.1.3 Cherry-picked to 3.1.3 🚢 4.0.0 First shipped in 4.0.0 labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🍒 3.1.0 Cherry-picked to 3.1.0 🍒 3.1.1 Cherry-picked to 3.1.1 🍒 3.1.2 Cherry-picked to 3.1.2 🍒 3.1.3 Cherry-picked to 3.1.3 🚢 4.0.0 First shipped in 4.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar chart with numeric x-axis fails to truncate upper bounds y-axis does not extend to cover max data values

5 participants