chore: improve CSP add base uri restriction#26251
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26251 +/- ##
==========================================
- Coverage 69.21% 69.17% -0.05%
==========================================
Files 1941 1942 +1
Lines 75910 75947 +37
Branches 8458 8458
==========================================
- Hits 52541 52536 -5
- Misses 21174 21216 +42
Partials 2195 2195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@rusackas do we have any front-end logging enabled by default? This might affect any telemetry we might have recently added |
I think we'll be OK with the telemetry. The PR is still open until I sort out the tests, but the only change to the CSP change there just pokes a couple holes in the |
(cherry picked from commit 578a899)
(cherry picked from commit 578a899)
(cherry picked from commit 578a899)
SUMMARY
Improves our current default CSP policy by adding
base-uritoself. base-uri directive restricts the URLs which can be used in a document's element.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION