Skip to content

fix(explore): redandant force param #25985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinpark merged 1 commit into from
Nov 16, 2023
Merged

fix(explore): redandant force param #25985

justinpark merged 1 commit into from
Nov 16, 2023

Conversation

@justinpark
Copy link
Member

@justinpark justinpark commented Nov 14, 2023

SUMMARY

The chartDataUrl contains an empty force parameter due to null value from getUrlParam(URL_PARAMS.force).
This commit cleans out the redundant force parameter for the falsy value case.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2023-11-14 at 11 51 39 AM

After:

Screenshot 2023-11-14 at 11 52 01 AM

TESTING INSTRUCTIONS

Go to any dashboard and check the url parameter for /api/v1/chart/data

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

john-bodley commented Nov 14, 2023

Thanks for the cleanup @justinpark, removing the bare force parameter helps greatly with the readability as previously it was akin to saying force=false which was somewhat misleading.

villebro
villebro approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 👍

@justinpark justinpark merged commit e7a1876 into apache:master Nov 16, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Nov 17, 2023
michael-s-molina pushed a commit that referenced this pull request Nov 20, 2023
@justinpark @michael-s-molina
fix(explore): redandant force param (#25985)
e3fbb01 
(cherry picked from commit e7a1876)
saghatelian added a commit to 10webio/superset that referenced this pull request Nov 27, 2023
@saghatelian @giftig
@Khrol @Always-prog @dpgaspar @rtexelm @geido @betodealmeida @justinpark @eschutho @john-bodley @michael-s-molina @mapledan @SA-Ark @Antonio-RiveroMartnez @kgabryje @FGrobelny @ggbaro @villebro @hughhhh @josedev-union @yousoph @jfrag1
3.0 (#3)
8651b24 
* fix(sqllab): reinstate "Force trino client async execution" (apache#25680)

* fix: remove unnecessary redirect (apache#25679)

(cherry picked from commit da42bf2)

* fix(chore): dashboard requests to database equal the number of slices it has (apache#24709)

(cherry picked from commit 75a7431)

* fix: bump to FAB 4.3.9 remove CSP exception (apache#25712)

(cherry picked from commit 8fb0c8d)

* fix(horizontal filter label): show full tooltip with ellipsis (apache#25732)

(cherry picked from commit e4173d9)

* fix: Revert "fix(Charts): Set max row limit + removed the option to use an empty row limit value" (apache#25753)

(cherry picked from commit e2fe967)

* fix: dataset update uniqueness (apache#25756)

(cherry picked from commit c7f8d11)

* fix(sqllab): slow pop datasource query (apache#25741)

(cherry picked from commit 2a2bc82)

* fix: allow for backward compatible errors (apache#25640)

* fix: DB-specific quoting in Jinja macro (apache#25779)

(cherry picked from commit 5659c87)

* fix: Revert "fix: Apply normalization to all dttm columns (apache#25147)" (apache#25801)

* fix: Resolve issue apache#24195 (apache#25804)

(cherry picked from commit 8737a8a)

* fix(SQL field in edit dataset modal): display full sql query (apache#25768)

(cherry picked from commit 1eba712)

* fix(sqllab): infinite fetching status after results are landed (apache#25814)

(cherry picked from commit 3f28eeb)

* fix: Fires onChange when clearing all values of single select (apache#25853)

(cherry picked from commit 8061d5c)

* fix: the temporal x-axis results in a none time_range. (apache#25429)

Co-authored-by: Elizabeth Thompson <[email protected]>
(cherry picked from commit ae619b1)

* fix(table chart): Show Cell Bars correctly apache#25625 (apache#25707)

(cherry picked from commit 916f7bc)

* fix: remove `update_charts_owners` (apache#25843)

* fix(charts): Time grain is None when dataset uses Jinja (apache#25842)

(cherry picked from commit 7536dd1)

* fix: Saving Mixed Chart with dashboard filter applied breaks adhoc_filter_b (apache#25877)

(cherry picked from commit 268c1dc)

* fix: database version field (apache#25898)

(cherry picked from commit 06ffcd2)

* fix: trino cursor (apache#25897)

(cherry picked from commit cdb18e0)

* chore: Updates CHANGELOG.md for 3.0.2

* fix(trino): allow impersonate_user flag to be imported (apache#25872)

Co-authored-by: John Bodley <[email protected]>
(cherry picked from commit 458be8c)

* fix(table): Double percenting ad-hoc percentage metrics (apache#25857)

(cherry picked from commit 784a478)

* fix(sqllab): invalid sanitization on comparison symbol (apache#25903)

(cherry picked from commit 581d3c7)

* fix: update flask-caching to avoid breaking redis cache, solves apache#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <[email protected]>

* fix: always denorm column value before querying values (apache#25919)

* chore(colors): Updating Airbnb brand colors (apache#23619)

(cherry picked from commit 6d8424c)

* fix: naming denomalized to denormalized in helpers.py (apache#25973)

(cherry picked from commit 5def416)

* fix(helm): Restart all related deployments when bootstrap script changed (apache#25703)

* fix(rls): Update text from tables to datasets in RLS modal (apache#25997)

(cherry picked from commit 210f1f8)

* fix: Make Select component fire onChange listener when a selection is pasted in (apache#25993)

(cherry picked from commit 5fccf67)

* fix(explore): redandant force param (apache#25985)

(cherry picked from commit e7a1876)

* chore: Optimize fetching samples logic (apache#25995)

(cherry picked from commit 326ac4a)

* fix(native filters): rendering performance improvement by reduce overrendering (apache#25901)

(cherry picked from commit e1d73d5)

* fix: update FAB to 4.3.10, Azure user info fix (apache#26037)

(cherry picked from commit 628cd34)

* chore: Updates CHANGELOG.md for 3.0.2 (rc2)

---------

Co-authored-by: Rob Moore <[email protected]>
Co-authored-by: Igor Khrol <[email protected]>
Co-authored-by: Stepan <[email protected]>
Co-authored-by: Daniel Vaz Gaspar <[email protected]>
Co-authored-by: Ross Mabbett <[email protected]>
Co-authored-by: Geido <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: JUST.in DO IT <[email protected]>
Co-authored-by: Elizabeth Thompson <[email protected]>
Co-authored-by: John Bodley <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: mapledan <[email protected]>
Co-authored-by: Arko <[email protected]>
Co-authored-by: Antonio Rivero <[email protected]>
Co-authored-by: Kamil Gabryjelski <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: FGrobelny <[email protected]>
Co-authored-by: Giacomo Barone <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Hugh A. Miles II <[email protected]>
Co-authored-by: josedev-union <[email protected]>
Co-authored-by: yousoph <[email protected]>
Co-authored-by: Jack Fragassi <[email protected]>
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@justinpark @josedev-union
fix(explore): redandant force param (apache#25985)
85dcf23
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@justinpark
fix(explore): redandant force param (apache#25985)
d7f55f5
@mistercrunch mistercrunch added 🍒 3.0.2 Cherry-picked to 3.0.2 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
fix(explore): redandant force param (apache#25985)
6e57ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@villebro villebro villebro approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.2 Cherry-picked to 3.0.2 🍒 3.0.3 Cherry-picked to 3.0.3 🍒 3.0.4 Cherry-picked to 3.0.4 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinpark @john-bodley @villebro @mistercrunch @michael-s-molina