Skip to content

fix: database version field #25898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
betodealmeida merged 1 commit into from
Nov 8, 2023
Merged

fix: database version field #25898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ const ExtraOptions = ({
</div>
<div className="input-container" data-test="version-spinbutton-test">
<input
type="number"
type="text"
name="version"
placeholder={t('Version number')}
onChange={onExtraInputChange}
Expand All @@ -550,8 +550,8 @@ const ExtraOptions = ({
</div>
<div className="helper">
{t(
'Specify the database version. This should be used with ' +
'Presto in order to enable query cost estimation.',
'Specify the database version. This is used with Presto for query cost ' +
'estimation, and Dremio for syntax changes, among others.',
)}
</div>
</StyledInputContainer>
Expand Down