Skip to content

fix(sqllab): slow pop datasource query #25741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinpark merged 2 commits into from
Oct 26, 2023
Merged

fix(sqllab): slow pop datasource query #25741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70e86de
fix(sqllab): slow pop datasource query
justinpark Oct 23, 2023
7c26cb5
missing keys
justinpark Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion superset-frontend/src/SqlLab/actions/sqlLab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,8 +1395,14 @@ export function popDatasourceQuery(datasourceKey, sql) {
return function (dispatch) {
const QUERY_TEXT = t('Query');
const datasetId = datasourceKey.split('__')[0];

const queryParams = rison.encode({
keys: ['none'],
columns: ['name', 'schema', 'database.id', 'select_star'],
});

return SupersetClient.get({
endpoint: `/api/v1/dataset/${datasetId}?q=(keys:!(none))`,
endpoint: `/api/v1/dataset/${datasetId}?q=${queryParams}`,
})
.then(({ json }) =>
dispatch(
Expand Down