Skip to content

feat: add France's regions to country map visualization#25673

Closed
dmeaux wants to merge 0 commit intoapache:masterfrom
dmeaux:master
Closed

feat: add France's regions to country map visualization#25673
dmeaux wants to merge 0 commit intoapache:masterfrom
dmeaux:master

Conversation

@dmeaux
Copy link
Copy Markdown
Contributor

@dmeaux dmeaux commented Oct 17, 2023

SUMMARY

This adds France's regions in addition to its departments for the country map visualization.

The regions are simplified have simplified geometries of the polygons taken from IGN's (France's National Geographic Institute) BD TOPO data with ISO 3166-02 codes added for each region.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

France's Departments
france_departments

France's Regions
france_regions

TESTING INSTRUCTIONS

(https://superset.apache.org/docs/miscellaneous/country-map-tools/)

ADDITIONAL INFORMATION

  • Has associated issue: Countries map - Add France Regions in addition to France Departments #25672
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@dmeaux dmeaux marked this pull request as draft October 17, 2023 09:30
@dmeaux dmeaux closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant