Skip to content

fix: Address Mypy issue which is causing CI to fail #25494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
john-bodley merged 2 commits into from
Oct 2, 2023
Merged

fix: Address Mypy issue which is causing CI to fail #25494

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84e134
fix: Address Mypy issue which is causing CI to fail
john-bodley Oct 2, 2023
4ac7a7b
Fix import order
john-bodley Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/unit_tests/db_engine_specs/test_clickhouse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
String,
TypeEngine,
)
from urllib3.connection import HTTPConnection
from urllib3.exceptions import NewConnectionError

from superset.utils.core import GenericDataType
from tests.unit_tests.db_engine_specs.utils import (
Expand All @@ -56,14 +58,12 @@ def test_convert_dttm(


def test_execute_connection_error() -> None:
from urllib3.exceptions import NewConnectionError

from superset.db_engine_specs.clickhouse import ClickHouseEngineSpec
from superset.db_engine_specs.exceptions import SupersetDBAPIDatabaseError

cursor = Mock()
cursor.execute.side_effect = NewConnectionError(
"Dummypool", "Exception with sensitive data"
HTTPConnection("localhost"), "Exception with sensitive data"
)
with pytest.raises(SupersetDBAPIDatabaseError) as ex:
ClickHouseEngineSpec.execute(cursor, "SELECT col1 from table1")
Expand Down