Skip to content

fix(SqlLab): make icon placement even #25372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgabryje merged 4 commits into from
Sep 28, 2023
Merged

fix(SqlLab): make icon placement even #25372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c5e116
sqllab-iconfix
CorbinBullard Sep 22, 2023
e6802ac
fixed unrelated changes
CorbinBullard Sep 23, 2023
ffc6830
ran-lint
CorbinBullard Sep 25, 2023
2d8ec8b
removed padding
CorbinBullard Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ const collapseStyles = (theme: SupersetTheme) => css`
padding: 0px ${theme.gridUnit * 4}px 0px 0px !important;
}
.ant-collapse-arrow {
top: ${theme.gridUnit * 2}px !important;
padding: 0 !important;
bottom: ${theme.gridUnit}px !important;
right: ${theme.gridUnit * 4}px !important;
Copy link
Member

@kgabryje kgabryje Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need those styles? It looks like the arrow is correctly centred when you just remove the padding (see screenshot).

image

Copy link
Member

@kgabryje kgabryje Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I wish we could clean up those !important statements... but we can leave that for another PR/task

color: ${theme.colors.primary.dark1} !important;
&:hover {
color: ${theme.colors.primary.dark2} !important;
Expand Down
5 changes: 5 additions & 0 deletions superset-frontend/src/SqlLab/components/TableElement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,11 @@ const TableElement = ({ table, ...props }: TableElementProps) => {
display: flex;
column-gap: ${theme.gridUnit * 1.5}px;
margin-right: ${theme.gridUnit}px;
& span {
display: flex;
justify-content: center;
width: ${theme.gridUnit * 4}px;
}
`}
>
{keyLink}
Expand Down