Skip to content

chore(colors): Updating Airbnb brand colors #23619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
john-bodley merged 2 commits into from
Nov 13, 2023
Merged

chore(colors): Updating Airbnb brand colors #23619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f197e3
chore(colors): Updating Airbnb branch colors
john-bodley Apr 6, 2023
13bf99d
Update editmode.test.ts
john-bodley Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ describe('Dashboard edit', () => {
// label Anthony
cy.get('[data-test-chart-name="Trends"] .line .nv-legend-symbol')
.eq(2)
.should('have.css', 'fill', 'rgb(0, 122, 135)');
.should('have.css', 'fill', 'rgb(244, 176, 42)');

// open main tab and nested tab
openTab(0, 0);
Expand All @@ -526,7 +526,7 @@ describe('Dashboard edit', () => {
'[data-test-chart-name="Top 10 California Names Timeseries"] .line .nv-legend-symbol',
)
.first()
.should('have.css', 'fill', 'rgb(0, 122, 135)');
.should('have.css', 'fill', 'rgb(244, 176, 42)');
});

it('should apply the color scheme across main tabs', () => {
Expand Down Expand Up @@ -557,7 +557,7 @@ describe('Dashboard edit', () => {

cy.get('[data-test-chart-name="Trends"] .line .nv-legend-symbol')
.first()
.should('have.css', 'fill', 'rgb(204, 0, 134)');
.should('have.css', 'fill', 'rgb(156, 52, 152)');

// change scheme now that charts are rendered across the main tabs
editDashboard();
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/e2e/explore/visualizations/dist_bar.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ describe('Visualization > Distribution bar chart', () => {
).should('exist');
cy.get('.dist_bar .nv-legend .nv-legend-symbol')
.first()
.should('have.css', 'fill', 'rgb(255, 90, 95)');
.should('have.css', 'fill', 'rgb(41, 105, 107)');
});
});
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/e2e/explore/visualizations/line.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('Visualization > Line', () => {
).should('exist');
cy.get('.line .nv-legend .nv-legend-symbol')
.first()
.should('have.css', 'fill', 'rgb(255, 90, 95)');
.should('have.css', 'fill', 'rgb(41, 105, 107)');
});

it('should work with adhoc metric', () => {
Expand Down
34 changes: 13 additions & 21 deletions superset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/airbnb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,19 @@ const schemes = [
id: 'bnbColors',
label: 'Airbnb Colors',
colors: [
'#ff5a5f', // rausch
'#7b0051', // hackb
'#007A87', // kazan
'#00d1c1', // babu
'#8ce071', // lima
'#ffb400', // beach
'#b4a76c', // barol
'#ff8083',
'#cc0086',
'#00a1b3',
'#00ffeb',
'#bbedab',
'#ffd266',
'#cbc29a',
'#ff3339',
'#ff1ab1',
'#005c66',
'#00b3a5',
'#55d12e',
'#b37e00',
'#988b4e',
'#29696B',
'#5BCACE',
'#F4B02A',
'#F1826A',
'#792EB2',
'#C96EC6',
'#921E50',
'#B27700',
'#9C3498',
'#9C3498',
'#E4679D',
'#C32F0E',
'#9D63CA',
],
},
].map(s => new CategoricalScheme(s));
Expand Down
2 changes: 1 addition & 1 deletion ...ckages/superset-ui-demo/storybook/stories/plugins/legacy-plugin-chart-map-box/Stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const Basic = () => {
allColumnsY: 'LAT',
clusteringRadius: '60',
globalOpacity: 1,
mapboxColor: 'rgb(0, 122, 135)',
mapboxColor: 'rgb(244, 176, 42)',
mapboxLabel: [],
mapboxStyle: 'mapbox://styles/mapbox/light-v9',
pandasAggfunc: 'sum',
Expand Down