Skip to content

fix:#22127#23489

Closed
Naveench131 wants to merge 1 commit into
apache:masterfrom
Naveench131:fix-Import-dashboard/assets-with-overwrite-flag-does-not-replace-dashboards-#22127
Closed

fix:#22127#23489
Naveench131 wants to merge 1 commit into
apache:masterfrom
Naveench131:fix-Import-dashboard/assets-with-overwrite-flag-does-not-replace-dashboards-#22127

Conversation

@Naveench131
Copy link
Copy Markdown

@Naveench131 Naveench131 commented Mar 27, 2023

…ds #22127

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Naveench131 Naveench131 marked this pull request as draft March 27, 2023 06:04
@Naveench131 Naveench131 changed the title Import dashboard/assets with overwrite flag does not replace dashboar… fix:#22127 Mar 27, 2023
@Naveench131 Naveench131 marked this pull request as ready for review March 27, 2023 06:06
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Copy Markdown
Member

rusackas commented Feb 9, 2024

@Naveench131 can you please give this PR a rebase, and fill out the PR description with the motivaion/risks/etc? I'll convert this to a draft in the meantime, but please make it "ready for review" when it's ready! Thanks!

@rusackas
Copy link
Copy Markdown
Member

rusackas commented Dec 9, 2024

Closing this since it hasn't been touched in nearly a year, but happy to reopen it if you ever want to revisit/update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants