Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#23176): adding URL decoding to SQLAlchemy URI #23421

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix(#23176): adding URL decoding to SQLAlchemy URI #23421

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b90984
bug fix 23176
RekhaZemoso Mar 20, 2023
a207bad
Trying to make the linter happy.
rusackas Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/migrations/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import logging
from logging.config import fileConfig
from typing import List
import urllib.parse
rusackas marked this conversation as resolved.
Show resolved Hide resolved

from alembic import context
from alembic.operations.ops import MigrationScript
Expand All @@ -42,7 +43,8 @@
"SQLite Database support for metadata databases will \
be removed in a future version of Superset."
)
config.set_main_option("sqlalchemy.url", DATABASE_URI)
decoded_uri = urllib.parse.unquote(DATABASE_URI)
config.set_main_option("sqlalchemy.url", decoded_uri)
target_metadata = Base.metadata # pylint: disable=no-member


Expand Down