fix(ui): disable json download when can csv on Superset is not allowed

[mgorsk1]

SUMMARY

Disables saving artifacts to JSON when canDownloadCSV is not allowed. This is required to prevent leaking data from superset. can csv on Superset is a permission aiming to prevent downloading structured data from Superset but it's not covering JSON exports. This PR aims to fix this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Not possible to disable export to json on charts #19535
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

LGTM, although I think the linter may complain about the long line

[villebro]

@mgorsk1 can you check if you were actually able to download the JSON data? I assume you should get an error if you don't have the right perms, and if you're not, we need to also fix this in the API.

[mgorsk1]

hey villebro, on a second thought I think that downloading JSON itself might be always valuable and we shall just strip it of data section when canDownloadCSV is false. wdyt?

[mgorsk1]

bump @villebro

[villebro]

Hi @mgorsk1 - CI is failing due to a linting issue:

[rusackas]

@mgorsk1 feel free to hit us up on Slack if we can help with linting. It also appears there are some conflicts to mitigate, hopefully that's straightforward-ish :) Would love to see #19535 closed. @Larissa-Rocha might also want to take a look at this PR on that note.

[mgorsk1]

fixed linting (I hope), feel free to re-run the CI @rusackas

[rusackas]

Resolved the conflict... hopefully CI passes ;)

[rusackas]

Ugh... I can't reboot the unit tests (which were probably just flaky) for some reason, so I'm going to close/reopen this to kick-start CI (again)

[rusackas]

Unit tests seem to be failing pretty reliably... can you run/address the tests locally? I also believe that a unit tests was fixed on master not long ago, so you might get lucky with a rebase.

[rusackas]

@mgorsk1 just checking to see if you have any interest in pursuing this still.

[rusackas]

Closing and re-opening to see if anything magically changes, but unless @mgorsk1 wants to check/fix unit tests, we might wind up closing this one for good.

[mgorsk1]

rebased @rusackas

[rusackas]

Closing/reopening to kick CI.

[rusackas]

Tests still seem to be failing on this. Any chance you can run them locally and see if you can get them to pass? I wonder if it's because the UI changed since the PR was opened.

[michael-s-molina]

Ci is failing with:

SyntaxError: /home/runner/work/superset/superset/superset-frontend/src/types/dom-to-pdf.d.ts: A 'const' initializer in an ambient context must be a string or numeric literal or literal enum reference.

#27236 was merged recently, so I think this PR just needs a rebase and it will be good to go.

[rusackas]

@mgorsk1 would you mind rebasing this so we can merge it?

[rusackas]

Still in need of a rebase here, I think, but I'll close/reopen again in a bit of a "hail mary" attempt.

[rusackas]

Looks like this still needs a rebase to pass CI. It's been a long while since it was touched, so I'll convert it to Draft. We may circle back and close it in time if it doesn't get any touch-ups. Please mark it as ready for review if/when it's ready, and we'll happily merge it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (d6fde3c) to head (478699f).
Report is 2959 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #22454   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files        1938     1938           
  Lines       75831    75831           
  Branches     8427     8427           
=======================================
  Hits        52328    52328           
  Misses      21334    21334           
  Partials     2169     2169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sadpandajoe]

Closed in favor of #28429