Skip to content

feat(db_engine_specs): Allow uploaded columns of dtype datetime to be stored as TIMESTAMP in the Hive schema #21850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GerbenvdHuizen wants to merge 3 commits into from
Closed

feat(db_engine_specs): Allow uploaded columns of dtype datetime to be stored as TIMESTAMP in the Hive schema #21850

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fc619d
Allow columns of dtype datetime to be stored as TIMESTAMP in the Hive…
GerbenvdHuizen Oct 18, 2022
2f8f77c
Add integration test for checking schema_definition in df_to_sql
GerbenvdHuizen Oct 19, 2022
40a5454
Fixed broken test
GerbenvdHuizen Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions superset/db_engine_specs/hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def _get_hive_type(dtype: np.dtype) -> str:
np.dtype("float64"): "DOUBLE",
np.dtype("int64"): "BIGINT",
np.dtype("object"): "STRING",
np.dtype("datetime64[ns]"): "TIMESTAMP",
}

return hive_type_by_dtype.get(dtype, "STRING")
Expand Down