Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump FAB to 4.1.2 #20483

Merged
merged 2 commits into from
Jun 24, 2022
Merged

fix: bump FAB to 4.1.2 #20483

merged 2 commits into from
Jun 24, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 23, 2022

SUMMARY

Improvements and Bug fixes on 4.1.2

Improvements and Bug fixes on 4.1.1

Improvements and Bug fixes on 4.1.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #20483 (d79ad4d) into master (aa40680) will increase coverage by 15.54%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #20483       +/-   ##
===========================================
+ Coverage   51.20%   66.75%   +15.54%     
===========================================
  Files        1740     1740               
  Lines       65156    65156               
  Branches     6900     6900               
===========================================
+ Hits        33362    43493    +10131     
+ Misses      30045    19914    -10131     
  Partials     1749     1749               
Flag Coverage Δ
hive 53.71% <100.00%> (?)
mysql 82.33% <100.00%> (?)
postgres 82.40% <100.00%> (?)
presto 53.57% <100.00%> (?)
python 82.84% <100.00%> (+32.29%) ⬆️
sqlite 82.19% <100.00%> (?)
unit 50.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/views.py 91.26% <100.00%> (+3.96%) ⬆️
superset/views/access_requests.py 95.45% <100.00%> (+9.09%) ⬆️
superset/views/annotations.py 81.96% <100.00%> (ø)
superset/views/css_templates.py 96.66% <100.00%> (ø)
superset/views/log/views.py 95.00% <100.00%> (+10.00%) ⬆️
superset/views/sql_lab.py 60.26% <100.00%> (+3.97%) ⬆️
superset/config.py 91.41% <0.00%> (+0.33%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/initialization/__init__.py 91.51% <0.00%> (+1.06%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa40680...d79ad4d. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit c56e37c into apache:master Jun 24, 2022
@dpgaspar dpgaspar deleted the fix/bum-fab-4.1.2 branch June 24, 2022 18:13
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants