Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table viz sort icon bottom aligned #20447

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Bottom aligning the sort icon looks better for multi line column names

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-06-21 at 04 20 49

After:

Screen Shot 2022-06-21 at 04 16 12

TESTING INSTRUCTIONS

Create a table visualization with many many columns, enough that the title of one of them breaks to more than one line.
Ensure the sorting icon bottom aligns.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #20447 (c94c814) into master (c79b0d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20447   +/-   ##
=======================================
  Coverage   66.72%   66.72%           
=======================================
  Files        1740     1740           
  Lines       65175    65175           
  Branches     6895     6895           
=======================================
  Hits        43486    43486           
  Misses      19940    19940           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/plugin-chart-table/src/TableChart.tsx 38.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79b0d6...c94c814. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 93774d1 into apache:master Jun 21, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants