Skip to content

fix(TextControl/TextAreaControl): Make TextControl/TextAreaControl sync state.value from props.value#20241

Closed
Renderz wants to merge 4 commits intoapache:masterfrom
Renderz:pr-text-control-controlled
Closed

fix(TextControl/TextAreaControl): Make TextControl/TextAreaControl sync state.value from props.value#20241
Renderz wants to merge 4 commits intoapache:masterfrom
Renderz:pr-text-control-controlled

Conversation

@Renderz
Copy link
Contributor

@Renderz Renderz commented Jun 2, 2022

SUMMARY

Make TextAreaControl component to be controlled, the props.value could be injected and be rendered correctly.

TextAreaControl should function the same way as TextControl.

I tested the cases mentioned here, and no interrupted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

2022-06-02.16.46.46.mov

After:

2022-06-02.16.47.24.mov

TESTING INSTRUCTIONS

Create a instance of TextAreaControl of which value is controlled, then trigger state changing.

TextAreaControl should render the changed value.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Renderz Renderz changed the title fix(TextAreaControl): Make TextAreaControl controlled fix(TextControl/TextAreaControl): Make TextControl/TextAreaControl sync state.value from props.value Jun 2, 2022
@Renderz
Copy link
Contributor Author

Renderz commented Jun 2, 2022

I checked that the core problem is that TextControl/TextAreaControl will not sync the state from props, and will cause that the value they display is not same as the value be given.

@rusackas
Copy link
Member

@Renderz sorry this is still lingering... but it'll need a rebase to move forward. This should also help it pass CI. I'll move this to draft mode for now, but if it becomes ready for review again, I'll try to find more reviewers.

@rusackas rusackas marked this pull request as draft October 30, 2024 17:29
@rusackas
Copy link
Member

This has sat untouched in draft mode for quite a while, so we'll go ahead and close it. We welcome you to reopen it if you want to contribute the change. Thank you for your contribution nonetheless!

@rusackas rusackas closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments