fix(TextControl/TextAreaControl): Make TextControl/TextAreaControl sync state.value from props.value#20241
Closed
Renderz wants to merge 4 commits intoapache:masterfrom
Closed
fix(TextControl/TextAreaControl): Make TextControl/TextAreaControl sync state.value from props.value#20241Renderz wants to merge 4 commits intoapache:masterfrom
Renderz wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
I checked that the core problem is that TextControl/TextAreaControl will not sync the state from props, and will cause that the value they display is not same as the value be given. |
Member
|
@Renderz sorry this is still lingering... but it'll need a rebase to move forward. This should also help it pass CI. I'll move this to draft mode for now, but if it becomes ready for review again, I'll try to find more reviewers. |
Member
|
This has sat untouched in draft mode for quite a while, so we'll go ahead and close it. We welcome you to reopen it if you want to contribute the change. Thank you for your contribution nonetheless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make TextAreaControl component to be controlled, the props.value could be injected and be rendered correctly.
TextAreaControl should function the same way as TextControl.
I tested the cases mentioned here, and no interrupted.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
2022-06-02.16.46.46.mov
After:
2022-06-02.16.47.24.mov
TESTING INSTRUCTIONS
Create a instance of TextAreaControl of which value is controlled, then trigger state changing.
TextAreaControl should render the changed value.
ADDITIONAL INFORMATION