Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(requirements): Cleanup of Python requirements #20154

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

As titled. Cleaning up the Python requirements (w/o bumping). The change removes unnecessary inclusions and leverages the . -e[...] format to include extras by adhering to the DRY principle which should help reduce the level of maintenance.

The change was made via,

pip-compile-multi --no-upgrade

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -15,10 +15,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency.

@john-bodley john-bodley force-pushed the john-bodley--cleanup-input-requirements branch from 500a140 to 72e7dba Compare May 22, 2022 02:42
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #20154 (f40eda3) into master (e07ee6c) will decrease coverage by 11.84%.
The diff coverage is n/a.

❗ Current head f40eda3 differs from pull request most recent head b200711. Consider uploading reports for the commit b200711 to get more accurate results

@@             Coverage Diff             @@
##           master   #20154       +/-   ##
===========================================
- Coverage   66.41%   54.56%   -11.85%     
===========================================
  Files        1726     1721        -5     
  Lines       64736    64513      -223     
  Branches     6826     6806       -20     
===========================================
- Hits        42993    35204     -7789     
- Misses      20010    27577     +7567     
+ Partials     1733     1732        -1     
Flag Coverage Δ
hive 53.72% <ø> (+0.01%) ⬆️
mysql ?
postgres ?
presto 53.57% <ø> (?)
python 58.02% <ø> (-24.51%) ⬇️
sqlite ?
unit 49.44% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
superset/datasets/commands/create.py 30.18% <0.00%> (-67.93%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/reports/commands/execute.py 24.45% <0.00%> (-67.16%) ⬇️
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07ee6c...b200711. Read the comment docs.

@john-bodley john-bodley force-pushed the john-bodley--cleanup-input-requirements branch from 72e7dba to d8f6a75 Compare May 22, 2022 03:09
docker
flask-testing
freezegun
google-cloud-bigquery
ipdb
# pinning ipython as pip-compile-multi was bringing higher version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erroneous comment.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clear-up. Thanks!

@john-bodley john-bodley merged commit 2a1dcaf into apache:master Jun 3, 2022
@john-bodley john-bodley deleted the john-bodley--cleanup-input-requirements branch June 3, 2022 15:35
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants