fix(hive): Workaround for Python 3.9 s3 transfer issue #19887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19887 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1714 1714
Lines 65032 65033 +1
Branches 6717 6717
=======================================
+ Hits 43260 43261 +1
Misses 20065 20065
Partials 1707 1707
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
May 4, 2022
superset/db_engine_specs/hive.py
Outdated
| @@ -80,6 +81,7 @@ def upload_to_s3(filename: str, upload_prefix: str, table: Table) -> str: | |||
| filename, | |||
| bucket_path, | |||
| os.path.join(upload_prefix, table.table, os.path.basename(filename)), | |||
| Config=TransferConfig(use_threads=False), | |||
There was a problem hiding this comment.
Suggested change
| Config=TransferConfig(use_threads=False), | |
| # Disabling threading because it breaks python 3.9 | |
| Config=TransferConfig(use_threads=False), |
There was a problem hiding this comment.
@etr2460 I inlined the comment.
jasonvank
pushed a commit
to CarbonEdge2021/superset
that referenced
this pull request
May 4, 2022
* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py
jasonvank
pushed a commit
to CarbonEdge2021/superset
that referenced
this pull request
May 4, 2022
* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix(hive): Workaround for Python 3.9 s3 transfer issue * Update hive.py
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR remedies an issue we (Airbnb) were facing after upgrading to Python 3.9. Per boto/s3transfer#197 (comment) there seems to be an s3 threading with Python 3.9+ causing the transfer to fail. Disabling threading seems to mitigate the issue. Note it's unclear what the potential performance impact is, especially when uploading large files.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and verified within an Airbnb environment.
ADDITIONAL INFORMATION