Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost renameOperator in mixed timeseries chart #19802

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Add renameOperator into MixedTimeseries chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #19802 (a727fb5) into master (4f997cd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19802   +/-   ##
=======================================
  Coverage   66.53%   66.54%           
=======================================
  Files        1692     1692           
  Lines       64777    64779    +2     
  Branches     6660     6661    +1     
=======================================
+ Hits        43101    43108    +7     
+ Misses      19977    19971    -6     
- Partials     1699     1700    +1     
Flag Coverage Δ
javascript 51.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 0.00% <ø> (ø)
...uperset-frontend/src/components/Collapse/index.tsx 90.00% <0.00%> (-10.00%) ⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <0.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <0.00%> (ø)
.../src/explore/components/controls/SliderControl.tsx 0.00% <0.00%> (ø)
...rc/explore/components/controls/CheckboxControl.jsx 100.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <0.00%> (ø)
.../shared-controls/components/RadioButtonControl.tsx 0.00% <0.00%> (ø)
...-frontend/src/explore/components/ControlHeader.tsx 83.33% <0.00%> (+0.72%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f997cd...a727fb5. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 108a2a4 into apache:master Apr 21, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants