Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable find text browser functionality inside SQL Lab editor #19061

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Disable the SQL Lab editor hotkey that prevents the find text browser functionality to work

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #19061 (469383f) into master (e89f0ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19061   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1641     1641           
  Lines       63476    63477    +1     
  Branches     6444     6444           
=======================================
+ Hits        42227    42228    +1     
  Misses      19585    19585           
  Partials     1664     1664           
Flag Coverage Δ
javascript 51.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 44.82% <100.00%> (+0.96%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 35.95% <0.00%> (ø)
superset-frontend/src/chart/chartReducer.ts
superset-frontend/src/chart/ChartErrorMessage.tsx
superset-frontend/src/chart/ChartRenderer.jsx
superset-frontend/src/chart/Chart.jsx
superset-frontend/src/chart/chartAction.js
superset-frontend/src/chart/ChartContainer.jsx
...rset-frontend/src/components/Chart/chartReducer.ts 25.00% <0.00%> (ø)
...et-frontend/src/components/Chart/ChartRenderer.jsx 44.89% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89f0ab...469383f. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@rusackas Ephemeral environment spinning up at http://34.217.82.223:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit fd757c4 into apache:master Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants