-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(explore): Set Drag&Drop feature flags to True by default #19046
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19046 +/- ##
==========================================
- Coverage 66.56% 66.32% -0.24%
==========================================
Files 1641 1641
Lines 63495 63476 -19
Branches 6425 6444 +19
==========================================
- Hits 42265 42103 -162
- Misses 19550 19707 +157
+ Partials 1680 1666 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We just need to fix the tests that expect these flags to be false.
@kgabryje would you mind also adding a line item to |
I'm not sure if we should include links to an internal issue tracking tool in the PR... it feels exclusive when someone not from your org cannot open the link. |
Agreed, let's drop that habit. Cross-linking issues in Github and Shortcut was supposed to help tracking them, but I don't think it's actually been useful. CC @rusackas |
SUMMARY
Flip
ENABLE_EXPLORE_DRAG_AND_DROP
andENABLE_DND_WITH_CLICK_UX
feature flags toTrue
by default. This will enable the drag and drop controls in the chart control panels in Explore pages.Related PRs: https://github.com/apache/superset/pulls?q=is%3Apr+is%3Aclosed+drag+and+drop+in%3Atitle%2Cbody+
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
https://app.shortcut.com/preset/story/39407/flip-dnd-feature-flags-2-0